Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD-372] SHIP-0021: Waiter's Base Image #977

Conversation

otaviof
Copy link
Member

@otaviof otaviof commented Jan 7, 2022

Changes

A #934 spinoff pull-request, to introduce the Waiter's base-image. The changes here are part of SHIP-0021 Local Source Upload.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

Prepration step for the Local Source Upload SHIP.
@otaviof otaviof added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 7, 2022
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Jan 7, 2022
@otaviof
Copy link
Member Author

otaviof commented Jan 7, 2022

/assign @SaschaSchwarze0

Please consider the changes here, as you pointed out in the original pull-request review.

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.8.0 milestone Jan 7, 2022
@otaviof
Copy link
Member Author

otaviof commented Jan 7, 2022

/assign @gabemontero @adambkaplan

@openshift-merge-robot openshift-merge-robot merged commit aeea9d8 into shipwright-io:main Jan 8, 2022
@otaviof otaviof deleted the ship-0021-waiter-base-image branch January 28, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants